fix(docker): align generated S3 and metrics credentials - #105
Open
satriadhikara wants to merge 1 commit into
Open
fix(docker): align generated S3 and metrics credentials#105satriadhikara wants to merge 1 commit into
satriadhikara wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix credential mismatches present in v1.14.1 and main:
Deployment evidence
These credential mismatches were encountered and corrected in our ITB Docker Compose deployment running v1.13.4. CSV upload returned HTTP 500 because SeaweedFS rejected the credentials used by Data Service.
After correcting both the Compose variable references and Data Service environment names, the application-consumed credentials matched SeaweedFS, and an authenticated S3 request returned HTTP 200.
The same mismatches remain in v1.14.1/main. This PR has configuration-level regression checks; live deployment testing of this branch remains pending.
Expected impact
Generated credentials reach Metadata Service, Data Service, and MySQL exporters consistently, instead of using default credentials that no longer match the generated configuration.
Type of Change
Related Issue
Related deployment context: #97. This PR does not resolve the installer failures tracked there.
Validation
The regression check covers both Compose files, default and custom S3 credentials, admin credentials, and both metrics output paths. It uses Docker Compose configuration rendering without starting containers. Database configuration generation runs only in temporary directories; it does not rotate deployment secrets or run sudo.
Checklist
Additional Notes
The full test suite and a live deployment smoke test have not been run. Installer, Valkey output-path, and exporter health-check fixes are outside this PR.
Existing deployments using S3_USER_* overrides must move those values to S3_ACCESS_KEY_ID and S3_SECRET_ACCESS_KEY. Do not rerun the entire secret generator on an existing deployment without coordinating credential rotation: persistent databases can retain their previous passwords.